Re: [Qemu-devel] [PATCH] piix: fix 32bit pci hole

[Jordan Justen]

On Tue, Nov 26, 2013 at 8:16 AM, Gerd Hoffmann <address@hidden> wrote:
> Make the 32bit pci hole start at end of ram, so all possible address
> space is covered.  Of course the firmware can use less than that.
> Leaving space unused is no problem, mapping pci bars outside the
> hole causes problems though.
>
> Signed-off-by: Gerd Hoffmann <address@hidden>
> ---
>  hw/pci-host/piix.c | 10 +---------

It seems like q35 should do something similar, but I'm not sure it
even looks at the ram size.

-Jordan

>  1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
> index edc974e..1414a2b 100644
> --- a/hw/pci-host/piix.c
> +++ b/hw/pci-host/piix.c
> @@ -345,15 +345,7 @@ PCIBus *i440fx_init(PCII440FXState **pi440fx_state,
>      f->ram_memory = ram_memory;
>
>      i440fx = I440FX_PCI_HOST_BRIDGE(dev);
> -    /* Set PCI window size the way seabios has always done it. */
> -    /* Power of 2 so bios can cover it with a single MTRR */
> -    if (ram_size <= 0x80000000) {
> -        i440fx->pci_info.w32.begin = 0x80000000;
> -    } else if (ram_size <= 0xc0000000) {
> -        i440fx->pci_info.w32.begin = 0xc0000000;
> -    } else {
> -        i440fx->pci_info.w32.begin = 0xe0000000;
> -    }
> +    i440fx->pci_info.w32.begin = ram_size;
>
>      memory_region_init_alias(&f->pci_hole, OBJECT(d), "pci-hole", 
> f->pci_address_space,
>                               pci_hole_start, pci_hole_size);
> --
> 1.8.3.1
>
>