[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] vmdk: Allow read only open of VMDK version
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] vmdk: Allow read only open of VMDK version 3 |
|
Date: |
Wed, 27 Nov 2013 12:32:01 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 27/11/2013 03:06, Fam Zheng ha scritto:
> + } else if (le32_to_cpu(header.version) == 3 && flags & BDRV_O_RDWR) {
Parentheses around "flags & BDRV_O_RDWR", please.
I'll try to patch checkpatch.pl to flag this.
Paolo
> + error_setg(errp, "VMDK version 3 must be read only");
> + return -EINVAL;
> }