[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_inpu
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor |
Date: |
Wed, 27 Nov 2013 18:10:17 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 27/11/2013 18:02, Markus Armbruster ha scritto:
> I have to admit I can't tell offhand what the heck QMP's netdev_add
> accepts, because I don't understand what "'*props:': '**'" means in
> qapi-schema.json. Even today, we permit code to serve as documentation
> and specification for new features. I wish we didn't.
It is ignored, because qmp_netdev_add does not use an
automatically-generated unmarshaler.
> Anyway, whatever it parses ends up in a QDict, as usual.
The QDict comes straight from the monitor dispatch. It is the QDict
that ordinarily would be unmarshaled by automatically-generated code.
> The part that sucks is the use of QemuOpts as netdev_add() parameter,
>
> It made some sense when it was done, because then the command line was
> the only user, its data type for option parameters was (and is)
> QemuOpts, and QemuOpts was the least inconvenient way to do a function
> that wants a a discriminated union of parameters, like netdev_add does.
>
> It stopped making sense when we started using it from QMP, whose data
> type for parameters is QDict. I shoehorned netdev_add into QMP in its
> early days. Hinsight 20/20...
Yes.
> In my opinion, use of QemuOpts for anything but parsing parameter
> strings has become a mistake.
Yes. OTOH QemuOpts is the only reason why QMP and HMP can use a common
back-end (netdev_add). With object-add you don't use QemuOpts (for good
reasons: you want to separate the human-oriented parsing and the
JSON-oriented parsing) and thus you need separate code for QMP and
HMP---at least for now.
The HMP code can use QemuOpts just like vl.c. The QMP code would use
qdict_iter or qdict_first/next and call object_set_property for each
element of the dictionary.
> Laszlo converted net.c to saner internal interfaces (commit
> d195325..1a0c095). Perhaps we can build on that.
Yeah, that could be an idea. Another is to convert netdevs to QOM
(reusing Laszlo's data structures of course) and then just use
object-add and -object.
Paolo
- [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, (continued)
- [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, Igor Mammedov, 2013/11/20
- Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, Markus Armbruster, 2013/11/21
- Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, Igor Mammedov, 2013/11/25
- Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, Michael S. Tsirkin, 2013/11/25
- Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, Paolo Bonzini, 2013/11/25
- Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, Eric Blake, 2013/11/25
- Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, Paolo Bonzini, 2013/11/25
- Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, Markus Armbruster, 2013/11/27
- Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, Paolo Bonzini, 2013/11/27
- Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor, Markus Armbruster, 2013/11/27
- Re: [Qemu-devel] [PATCH 05/27] qapi: add SIZE type parser to string_input_visitor,
Paolo Bonzini <=
[Qemu-devel] [PATCH 06/27] get reference to /backend container via qemu_get_backend(), Igor Mammedov, 2013/11/20
[Qemu-devel] [PATCH 07/27] add memdev backend infrastructure, Igor Mammedov, 2013/11/20
- Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure, Paolo Bonzini, 2013/11/25
- Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure, Igor Mammedov, 2013/11/25
- Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure, Paolo Bonzini, 2013/11/25
- Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure, Igor Mammedov, 2013/11/27
- Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure, Paolo Bonzini, 2013/11/27
- Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure, Igor Mammedov, 2013/11/27
Re: [Qemu-devel] [PATCH 07/27] add memdev backend infrastructure, Eric Blake, 2013/11/27