[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 29/60] AArch64: Add orri instruction emulation |
|
Date: |
Thu, 28 Nov 2013 10:56:05 +1300 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 11/27/2013 12:56 AM, Claudio Fontana wrote:
> On 09/27/2013 09:42 PM, Richard Henderson wrote:
>> On 09/26/2013 05:48 PM, Alexander Graf wrote:
>>> + if (setflags) {
>>> + tcg_dst = cpu_reg(dest);
>>> + } else {
>>> + tcg_dst = cpu_reg_sp(dest);
>>> + }
>>
>> Never sp for logicals.
>
> This should be ok in my view, the manual explicitly shows in the pseudocode:
>
> if d == 31 && !setflags then
> SP[] = result;
> else
> X[d] = result;
Sure enough. I mis-read that Logical (register) and Logical (immediate) are
different in their ability to use XSP as an output.
r~