Re: [Qemu-devel] [PATCH] fix compilation on FreeBSD for mac_*world.c

[Peter Maydell]

On 28 November 2013 21:33, Andreas Tobler <address@hidden> wrote:
> Hello,
>
> On 09.11.13 00:15, Andreas Tobler wrote:
>> Hello,
>>
>> the attached patch fixes compilation on FreeBSD for
>> hw/ppc/mac_new/oldworld.c on FreeBSD.
>>
>> The affected function is present in machine/param.h on FreeBSD:
>>
>> #define round_page(x)   ((((unsigned long)(x)) + PAGE_MASK) & ~(PAGE_MASK))
>>
>> To make it compile on FreeBSD I'd like to propose the below patch which
>> is in use since a longer time on the ports tree (FreeBSD) and in my
>> personal git tree.

Rather than doing this:
+ #if defined(__FreeBSD__)
+ #undef round_page
+ #endif

personally I'd prefer it if we just replaced the uses of round_page()
with TARGET_PAGE_ALIGN(), which is the macro we define in
the headers for aligning up to the next page size.

Up to the ppc submaintainers though...

thanks
-- PMM