[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/5] osdep: add qemu_set_tty_echo()
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 3/5] osdep: add qemu_set_tty_echo() |
|
Date: |
Fri, 29 Nov 2013 11:13:41 +0100 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 29.11.2013 um 11:04 hat Kevin Wolf geschrieben:
> Am 14.11.2013 um 11:54 hat Stefan Hajnoczi geschrieben:
> > Using stdin with readline.c requires disabling echo and line buffering.
> > Add a portable wrapper to set the terminal attributes under Linux and
> > Windows.
> >
> > Signed-off-by: Stefan Hajnoczi <address@hidden>
>
> There's already qemu_chr_fe_set_echo(). Can't we use that? Changing this
> setting outside the context of a chardev feels wrong anyway.
Okay, I see, tools don't have chardevs, unfortunately. But can we avoid
duplication the other way round then, that is, let qemu-char.c use the
new functions? They don't seem to be exactly the same, so I'm not
completely sure if they are supposed to do different things or if they
are just buggy in different ways.
Kevin
- [Qemu-devel] [PATCH 0/5] qemu-io: readline command completion, Stefan Hajnoczi, 2013/11/14
- [Qemu-devel] [PATCH 1/5] readline: decouple readline from the monitor, Stefan Hajnoczi, 2013/11/14
- [Qemu-devel] [PATCH 3/5] osdep: add qemu_set_tty_echo(), Stefan Hajnoczi, 2013/11/14
- [Qemu-devel] [PATCH 2/5] readline: move readline to a generic location, Stefan Hajnoczi, 2013/11/14
- [Qemu-devel] [PATCH 4/5] qemu-io: use readline.c, Stefan Hajnoczi, 2013/11/14
- [Qemu-devel] [PATCH 5/5] qemu-io: add command completion, Stefan Hajnoczi, 2013/11/14
- Re: [Qemu-devel] [PATCH 0/5] qemu-io: readline command completion, Luiz Capitulino, 2013/11/27