Re: [Qemu-devel] [fixed-up][PATCH v6 2/5] hw/timer: add sunxi timer device

[Peter Maydell]

On 27 November 2013 08:29, liguang <address@hidden> wrote:
> Signed-off-by: liguang <address@hidden>
> ---
>  default-configs/arm-softmmu.mak |    2 +
>  hw/timer/Makefile.objs          |    1 +
>  hw/timer/sunxi-pit.c            |  254 
> +++++++++++++++++++++++++++++++++++++++
>  include/hw/timer/sunxi-pit.h    |   56 +++++++++
>  4 files changed, 313 insertions(+), 0 deletions(-)
>  create mode 100644 hw/timer/sunxi-pit.c
>  create mode 100644 include/hw/timer/sunxi-pit.h


Please use scripts/checkpatch.pl on your patches:
it finds a lot of minor formatting errors which you
should fix. (It is not always correct but it will
spot things like missing spaces, use of hard tabs,
missing braces and so on.)

thanks
-- PMM