Re: [Qemu-devel] [PATCH 1/2] target-i386: fix cpuid leaf 0x0d

[Liu, Jinsong]

Paolo Bonzini wrote:
> Il 29/11/2013 14:15, Liu, Jinsong ha scritto:
>> From e4b58c7bafc4d9f913a572a1b1cfee91c92f1637 Mon Sep 17 00:00:00
>> 2001 
>> From: Liu Jinsong <address@hidden>
>> Date: Fri, 22 Nov 2013 00:24:16 +0800
>> Subject: [PATCH 1/2] target-i386: fix cpuid leaf 0x0d
>> 
>> Fix cpuid leaf 0x0d which incorrectly parsed eax and ebx.
> 
> There is no visible change right (the two hunks cancel each other)?
> Since you will have to post a v2, please make this explicit in the
> commit message.
> 

OK, will add explicit commit message, or, drop this patch if needed.

Thanks,
Jinsong

> 
>> Signed-off-by: Liu Jinsong <address@hidden>
>> ---
>>  target-i386/cpu.c |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
>> index 864c80e..544b57f 100644
>> --- a/target-i386/cpu.c
>> +++ b/target-i386/cpu.c
>> @@ -335,7 +335,7 @@ typedef struct ExtSaveArea {
>> 
>>  static const ExtSaveArea ext_save_areas[] = {
>>      [2] = { .feature = FEAT_1_ECX, .bits = CPUID_EXT_AVX,
>> -            .offset = 0x100, .size = 0x240 },
>> +            .offset = 0x240, .size = 0x100 },
>>  };
>> 
>>  const char *get_register_name_32(unsigned int reg)
>> @@ -2225,8 +2225,8 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t
>>              index, uint32_t count, const ExtSaveArea *esa =
>>              &ext_save_areas[count]; if
>>                  ((env->features[esa->feature] & esa->bits) ==
>> esa->bits && (kvm_mask & (1 << count)) != 0) { 
>> -                *eax = esa->offset;
>> -                *ebx = esa->size;
>> +                *eax = esa->size;
>> +                *ebx = esa->offset;
>>              }
>>          }
>>          break;
>> --
>> 1.7.1