qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 23/30] virtio-blk: Convert to QOM realize


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 23/30] virtio-blk: Convert to QOM realize
Date: Fri, 29 Nov 2013 17:08:36 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

Am 29.11.2013 11:17, schrieb Paolo Bonzini:
> diff --git a/tests/qdev-monitor-test.c b/tests/qdev-monitor-test.c
> index 33a8ea4..ba7f9cc 100644
> --- a/tests/qdev-monitor-test.c
> +++ b/tests/qdev-monitor-test.c
> @@ -32,10 +32,8 @@ static void test_device_add(void)
>                     "}}");
>      g_assert(response);
>      error = qdict_get_qdict(response, "error");
> -    g_assert(!strcmp(qdict_get_try_str(error, "class") ?: "",
> -                     "GenericError"));
>      g_assert(!strcmp(qdict_get_try_str(error, "desc") ?: "",
> -                     "Device initialization failed."));
> +                     "Device needs media, but drive is empty"));
>      QDECREF(response);
>  
>      /* Delete the drive */

Thanks for finding and fixing this qtest failure!

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]