[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH arm-devs v1 03/13] net/cadence_gem: Don't assert
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH arm-devs v1 03/13] net/cadence_gem: Don't assert against 0 buffer address |
Date: |
Mon, 2 Dec 2013 12:04:42 +0000 |
On 2 December 2013 07:10, Peter Crosthwaite
<address@hidden> wrote:
> This has no real hardware analog. Leave the error message in is as
> it is almost certainly a guest error, but fallthrough to the expected
> behaviour.
Maybe we should qemu_log_mask(LOG_GUEST_ERROR, ...) then?
> Signed-off-by: Peter Crosthwaite <address@hidden>
> ---
>
> hw/net/cadence_gem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
> index b84ee60..3f30caf 100644
> --- a/hw/net/cadence_gem.c
> +++ b/hw/net/cadence_gem.c
> @@ -694,7 +694,6 @@ static ssize_t gem_receive(NetClientState *nc, const
> uint8_t *buf, size_t size)
> if (rx_desc_get_buffer(desc) == 0) {
> DB_PRINT("Invalid RX buffer (NULL) for descriptor 0x%x\n",
> (unsigned)packet_desc_addr);
> - break;
> }
>
> /* Copy packet data to emulated DMA buffer */
> --
> 1.8.4.4
>
-- PMM
- [Qemu-devel] [PATCH arm-devs v1 00/13] Cadence GEM Bugfixes and missing features, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 01/13] net/cadence_gem: Implement mac level loopback mode, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 02/13] net/cadence_gem: Update DMA rx descriptors as we process them, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 03/13] net/cadence_gem: Don't assert against 0 buffer address, Peter Crosthwaite, 2013/12/02
- Re: [Qemu-devel] [PATCH arm-devs v1 03/13] net/cadence_gem: Don't assert against 0 buffer address,
Peter Maydell <=
- [Qemu-devel] [PATCH arm-devs v1 04/13] net/cadence_gem: simplify rx buf descriptor walking, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 05/13] net/cadence_gem: Prefetch rx descriptors ASAP, Peter Crosthwaite, 2013/12/02
- [Qemu-devel] [PATCH arm-devs v1 06/13] net/cadence_gem: Implement RX descriptor match mode flags, Peter Crosthwaite, 2013/12/02