[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH arm-devs v4 3/4] hw/timer: Introduce ARM A9 Glob
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH arm-devs v4 3/4] hw/timer: Introduce ARM A9 Global Timer. |
Date: |
Mon, 2 Dec 2013 12:36:08 +0000 |
On 2 December 2013 12:28, Andreas Färber <address@hidden> wrote:
> Am 02.12.2013 08:36, schrieb Peter Crosthwaite:
>> The ARM A9 MPCore has a timer that is global to all CPUs in the mpcore.
>> The timer is shared but each CPU has a private independent comparator
>> and interrupt.
>> + dc->no_user = 1;
>
> There is a series from Markus waiting on my review that renames and
> investigates all uses of this field. Please explain why you are using it
> (in form of a comment) or drop it. There's only a numeric property
> above, so likely the latter.
It's a sysbus device so it's never going to be usable via device-add.
I think Markus' patchset puts that check in the sysbus base class
though, which would make dropping the no_user here correct.
thanks
-- PMM
Re: [Qemu-devel] [PATCH arm-devs v4 0/4] A9 global timer + mpcore trivials, Peter Maydell, 2013/12/02