[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory.c: bugfix - ref counting mismatch in mem
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH] memory.c: bugfix - ref counting mismatch in memory_region_find |
|
Date: |
Mon, 02 Dec 2013 15:22:58 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130923 Thunderbird/17.0.9 |
Il 02/12/2013 15:20, Marcel Apfelbaum ha scritto:
> 'address_space_get_flatview' gets a reference to a FlatView.
> If the flatview lookup fails, the code returns without
> "unreferencing" the view.
>
> Cc: address@hidden
>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
> memory.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/memory.c b/memory.c
> index 28f6449..7764314 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -1596,6 +1596,7 @@ MemoryRegionSection memory_region_find(MemoryRegion *mr,
> view = address_space_get_flatview(as);
> fr = flatview_lookup(view, range);
> if (!fr) {
> + flatview_unref(view);
> return ret;
> }
>
>
Reviewed-by: Paolo Bonzini <address@hidden>