Re: [Qemu-devel] [Qemu-trivial] [PATCH] vl: remove (max_cpus > 255) check from smp_parse

[Michael Tokarev]

25.11.2013 07:39, Alexey Kardashevskiy wrote:
> Since modern POWER7/POWER8 chips can have more that 256 CPU threads
> (>2000 actually), remove this check from smp_parse.
> 
> The CPUs number is still checked against machine->max_cpus and this check
> should be enough not to break other archs.
[]
> -    if (max_cpus > 255) {
> -        fprintf(stderr, "Unsupported number of maxcpus\n");
> -        exit(1);
> -    }

I don't know whenever this is actually safe.  Do we have any static arrays
of size 255 somewhere, which will be overflowed without this check? :)

Thanks,

/mjt