Re: [Qemu-devel] [PATCHv4] qdev: Validate hex properties

[Eric Blake]

On 11/28/2013 11:48 PM, Hannes Reinecke wrote:
> strtoul(l) might overflow, in which case it'll return '-1' and set
> the appropriate error code. So update the calls to strtoul(l) when
> parsing hex properties to avoid silent overflows.
> And we should be using an intermediate variable to avoid clobbering
> of the passed-in point on error.
> 
> Signed-off-by: Hannes Reinecke <address@hidden>
> ---
>  hw/core/qdev-properties.c | 36 ++++++++++++++++++++++++++++++------
>  1 file changed, 30 insertions(+), 6 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature