Re: [Qemu-devel] [PATCH] arm: Raspberry Pi support

[Peter Maydell]

On 2 December 2013 11:11, Jan Petrouš <address@hidden> wrote:
>
> Initial commit. Added 'raspi' virtual platform and corresponding
> BCM2835 devices support.
>
> The code is (c) Gregory Estrade <address@hidden>
> retrieved from Greg's out-of-tree repository on github
> https://github.com/Torlus/qemu/tree/rpi
> and squashed the following commits:
>   4a9dcbd Timer fix (courtesy of Romain Caritey), LOG_REGISTERS disabled
>           by default in property handler.
>   9092a09 applied JacobL's patch on ATAGs
>   02bf596 rpi: Default resolution set to 640x480
>   c74ef39 rpi: Attempt to fix segfault in display update
>   db76ca8 rpi: sysbus_from_qdev replaced by SYS_BUS_DEVICE
>   1029033 rpi: pre-alpha USB controller emulation, fixes in VC->arm
>                property interface and eMMC interrupt generation.
>   48808d4 rpi: USB emulation started
>   dd26108 rpi: ARM timer emulation
>   527fd08 rpi: eMMC/fb enhancements, RiscOS is now booting.
>   7e4c052 rpi: property chaanel, ARM1176 cp15-c12 added, framebuffer
>                enhancements
>   a8c161d Fixed include paths
>   2f4f9fc Initial commit for Raspberry Pi support
>
> Upstreaming code cleaning by Jan Petrous <address@hidden>.
>
> Signed-off-by: Gregory Estrade <address@hidden>
> Signed-off-by: Jan Petrous <address@hidden>
> ---
>  hw/arm/Makefile.objs         |    5 +
>  hw/arm/bcm2835_arm_control.h |  481 +++++++++++++++++++
>  hw/arm/bcm2835_common.h      |   37 ++
>  hw/arm/bcm2835_dma.c         |  380 +++++++++++++++
>  hw/arm/bcm2835_emmc.c        |  861 ++++++++++++++++++++++++++++++++++
>  hw/arm/bcm2835_fb.c          |  379 +++++++++++++++
>  hw/arm/bcm2835_ic.c          |  255 ++++++++++
>  hw/arm/bcm2835_mphi.c        |  190 ++++++++
>  hw/arm/bcm2835_platform.h    |  230 +++++++++
>  hw/arm/bcm2835_power.c       |  117 +++++
>  hw/arm/bcm2835_property.c    |  413 ++++++++++++++++
>  hw/arm/bcm2835_sbm.c         |  293 ++++++++++++
>  hw/arm/bcm2835_st.c          |  218 +++++++++
>  hw/arm/bcm2835_timer.c       |  260 +++++++++++
>  hw/arm/bcm2835_todo.c        |   93 ++++
>  hw/arm/bcm2835_usb.c         |  777 +++++++++++++++++++++++++++++++
>  hw/arm/bcm2835_usb_regs.h    | 1061
> ++++++++++++++++++++++++++++++++++++++++++
>  hw/arm/bcm2835_vchiq.c       |  117 +++++
>  hw/arm/raspi.c               |  361 ++++++++++++++
>  19 files changed, 6528 insertions(+)

Hi. Thanks for this patch -- I'm sure there are a lot of people who'd
like to see raspberry pi emulation in upstream. However, I'm afraid
this patch is not reviewable in this format. You really need to break
it up into a series of smaller patches each of which add one device
or similarly sized feature.

You might like to read http://wiki.qemu.org/Contribute/SubmitAPatch
if you haven't already for some other information on how our
patch review process works. I'd also strongly recommend you browse
the list archives to look at what has been said about some other
recent series supplying ARM board support (like the sunxi and
DIGIC board patch series) -- review comments made in those email
threads about patch series structure, where source files should go
in the directory tree, how to model SoCs, etc are very likely to
apply to your series too.

thanks
-- PMM