Re: [Qemu-devel] [PATCH V2 5/8] qapi script: use same function to generate enum string

[Wenchao Xia]

于 2013/12/3 4:17, Eric Blake 写道:
> On 11/12/2013 03:25 PM, Wenchao Xia wrote:
> > One function one rule, so the enum string generating have same
> > behavior for different caller. If multiple caller exist for one
> > enum define in schema, it is for sure the generated string is
> > identical.
> >
> > Note before the patch qapi-visit.py used custom function to
> > generate the string in union visit, although the patch changes it,
> > the final string generated is not changed. The custom function used
> > before will met problem when capitalized discriminator value is
> > introduced.
>
> I'm finding this commit message awkward to read and rather wordy.  May I
> suggest the shorter:
>
> Prior to this patch, qapi-visit.py used custom code to generate enum
> names used for handling a qapi union.  Fix it to instead reuse common
> code, with identical generated results, and allowing future updates to
> generation to only need to touch one place.
  That sounds better, thanks for reviewing. I have sent v3 before at:
http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg03980.html
There is no change except better intro/doc, will use the new commit
message in V4.