Re: [Qemu-devel] [PATCH V3 8/9] qapi: convert BlockdevOptions to use enum discriminator

[Eric Blake]

On 11/29/2013 01:41 AM, Wenchao Xia wrote:
> After this patch, hidden enum type BlockdevOptionsKind will not
> be generated, and other API can use enum BlockdevDriver.
> 
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
>  qapi-schema.json |   14 +++++++++++++-
>  1 files changed, 13 insertions(+), 1 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 83fa485..ce9197d 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4024,6 +4024,18 @@
>              '*no-flush': 'bool' } }
>  
>  ##
> +# @BlockdevDriver
> +#
> +# Drivers that are supported in block device operations.
> +#
> +# Since: 2.0

It will be interesting documenting any drivers that are added after 2.0,
but we can worry about that when it happens.  Looks good!

Reviewed-by: Eric Blake <address@hidden>

> +##
> +{ 'enum': 'BlockdevDriver',
> +  'data': [ 'file', 'http', 'https', 'ftp', 'ftps', 'tftp', 'vvfat', 'bochs',
> +            'cloop', 'cow', 'dmg', 'parallels', 'qcow', 'qcow2', 'qed', 
> 'raw',
> +            'vdi', 'vhdx', 'vmdk', 'vpc' ] }
> +
> +##

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature