Re: [Qemu-devel] [PATCH arm-devs v2 8/8] arm/highbank.c: Fix MPCore periphbase name

[Peter Crosthwaite]

Hi Peter,

On Fri, Nov 29, 2013 at 10:09 AM, Peter Crosthwaite
<address@hidden> wrote:
> On Fri, Nov 29, 2013 at 5:41 AM, Peter Maydell <address@hidden> wrote:
>> On 28 November 2013 03:31, Peter Crosthwaite
>> <address@hidden> wrote:
>>> GIC_BASE_ADDR is not the base address of the GIC. Its clear from the
>>> code that this is the base address of the MPCore. Rename to
>>> MPCORE_PERIPHBASE accordingly.
>>
>> "MPCore" is one of those terms I dislike because it
>> doesn't actually match up with the documentation's
>> terminology...
>>
>

Which documentation are you specifically referring too? "MPCore" seems
to very much be a part of ARM top level documentation with document
names such as:

"ARM Cortex-A15 MPCore Processor Technical Reference Manual"

Regards,
Peter

> What entity ultimately owns PERIPHBASE and whats its symbolic name? I
> felt like PERIPHBASE on its own was wrong. GIC_BASE_ADDR seems very
> wrong though. Open to suggestion.
>