[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 03/15] input: define event types using qapi
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [RFC PATCH 03/15] input: define event types using qapi |
Date: |
Tue, 03 Dec 2013 09:11:13 +0100 |
On Mo, 2013-12-02 at 12:12 -0700, Eric Blake wrote:
> On 11/28/2013 07:29 AM, Gerd Hoffmann wrote:
> > Define input event types, using qapi. So we get nicely autogenerated
> > types for our input events. And when it comes to qmp support some day
> > things will be alot easier.
> >
> > Types are modeled after the linux input layer. There are separate
> > event types for each value. There is a sync to indicate the end
> > of a event group.
> >
> > Mouse events are splitted into motion events (one for each axis) and
>
> s/splitted/split/ (yes, one of those stupid English words whose
> past-tense spelling is the same as its present tense)
Thanks for the explanation. That hopefully makes it a bit easier to
remember.
> > +###########################################################
> > +# WIP - input event data structures
> > +# not exposed via qmp yet, needs testing first
>
> But still worth documenting, and adding "Since 2.0" annotations to each
> enum and struct.
Sure, already on the todo list for the final patch version.
cheers,
Gerd