Re: [Qemu-devel] [PATCH] vmdk: Fix creating big description file

[Stefan Hajnoczi]

On Tue, Dec 03, 2013 at 10:29:14AM +0800, Fam Zheng wrote:
> On 2013年12月02日 21:26, Stefan Hajnoczi wrote:
> >On Mon, Dec 02, 2013 at 11:01:20AM +0800, Fam Zheng wrote:
> >>The buffer for description file was 4096 which only covers a few
> >>hundred of extents. This changes the buffer to dynamic allocated with
> >>g_strdup_printf in order to support bigger cases.
> >>
> >>Signed-off-by: Fam Zheng <address@hidden>
> >>---
> >>  block/vmdk.c               |   65 +-
> >>  tests/qemu-iotests/059     |    5 +
> >>  tests/qemu-iotests/059.out | 2012 
> >> ++++++++++++++++++++++++++++++++++++++++++++
> >>  3 files changed, 2058 insertions(+), 24 deletions(-)
> >
> >Does VMware have a hard limit?  For example, does it open the 1000 GB
> >twoGbMaxExtentFlat file from your test case?
> >
> 
> Yes it does. The limit is far above this, there is a statement in
> VMDK spec: "Maximum VMDK file size is 2TB." It opens this file from
> the test case, however I can't generate such a twoGbMaxExtentFlat
> from Workstation, because it will be automatically forced to
> monolithicFlat (if the size is above certain threshold).

Okay, good.  Thanks for explaining.

Stefan