Re: [Qemu-devel] [PATCH v2] hw/i386/pc_sysfw: support two flash drives

[Paolo Bonzini]

Il 03/12/2013 18:23, Markus Armbruster ha scritto:
>> > +            /* push a new, "none" location on the location stack; 
>> > overwrite its
>> > +             * contents with the location saved in the option; print the 
>> > error
>> > +             * (includes location); pop the top
>> > +             */
> Sure this comment is worthwhile?  Your decision.
> 
> I suspect we should have error_report_loc().

Or qemu_opts_loc_push.

In any case, the comment is necessary but shouldn't be. :)

Paolo

>> > +            loc_push_none(&loc);
>> > +            if (pflash_drv->opts != NULL) {
>> > +                qemu_opts_loc_restore(pflash_drv->opts);
>> > +            }