[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/12] target-arm: Split A64 from A32/T32 gen_in
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH 01/12] target-arm: Split A64 from A32/T32 gen_intermediate_code_internal() |
Date: |
Wed, 04 Dec 2013 12:34:42 +1300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/04/2013 10:51 AM, Peter Maydell wrote:
> The A32/T32 gen_intermediate_code_internal() is complicated because it
> has to deal with:
> * conditionally executed instructions
> * Thumb IT blocks
> * kernel helper page
> * M profile exception-exit special casing
>
> None of these apply to A64, so putting the "this is A64 so
> call the A64 decoder" check in the middle of the A32/T32
> loop is confusing and means the A64 decoder's handling of
> things like conditional jump and singlestepping has to take
> account of the conditional-execution jumps the main loop
> might emit.
>
> Refactor the code to give A64 its own gen_intermediate_code_internal
> function instead.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target-arm/translate-a64.c | 209
> ++++++++++++++++++++++++++++++++++++++++++--
> target-arm/translate.c | 62 +++++--------
> target-arm/translate.h | 20 ++++-
> 3 files changed, 246 insertions(+), 45 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH 10/12] target-arm: A64: add support for conditional branches, (continued)
- [Qemu-devel] [PATCH 10/12] target-arm: A64: add support for conditional branches, Peter Maydell, 2013/12/03
- [Qemu-devel] [PATCH 02/12] target-arm: A64: add set_pc cpu method, Peter Maydell, 2013/12/03
- [Qemu-devel] [PATCH 03/12] target-arm: A64: provide functions for accessing FPCR and FPSR, Peter Maydell, 2013/12/03
- [Qemu-devel] [PATCH 04/12] target-arm: Support fp registers in gdb stub, Peter Maydell, 2013/12/03
- [Qemu-devel] [PATCH 01/12] target-arm: Split A64 from A32/T32 gen_intermediate_code_internal(), Peter Maydell, 2013/12/03
- Re: [Qemu-devel] [PATCH 01/12] target-arm: Split A64 from A32/T32 gen_intermediate_code_internal(),
Richard Henderson <=
- [Qemu-devel] [PATCH 11/12] target-arm: A64: add support for 'test and branch' imm, Peter Maydell, 2013/12/03
- [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm, Peter Maydell, 2013/12/03
- Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm, Richard Henderson, 2013/12/03
- Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm, Peter Maydell, 2013/12/03
- Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm, Richard Henderson, 2013/12/03
- Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm, Peter Maydell, 2013/12/04
- Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm, Peter Maydell, 2013/12/04
- Re: [Qemu-devel] [PATCH 12/12] target-arm: A64: add support for compare and branch imm, Richard Henderson, 2013/12/04