Re: [Qemu-devel] [PATCH arm-devs v1 03/13] net/cadence_gem: Don't assert against 0 buffer address

[Peter Crosthwaite]

On Mon, Dec 2, 2013 at 10:04 PM, Peter Maydell <address@hidden> wrote:
> On 2 December 2013 07:10, Peter Crosthwaite
> <address@hidden> wrote:
>> This has no real hardware analog. Leave the error message in is as
>> it is almost certainly a guest error, but fallthrough to the expected
>> behaviour.
>
> Maybe we should qemu_log_mask(LOG_GUEST_ERROR, ...)  then?
>

I'm starting to think this is not a peripherals assumption to make.
Theres nothing in the GEM design that suggests a 0 RX buffer address
is functionally incorrect. Its not good for Zynq, as theres an ARM
vector table there but thats Zynq's problem not GEMs. Peripherals
DMAing to non-sensical addresses is a SoC/Board level problem and I
think it should be solved there. I'm just going to delete this whole
check.

Regards,
Peter