[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC V3 2/7] block: Allow the user to define "node-name
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC V3 2/7] block: Allow the user to define "node-name" option. |
Date: |
Wed, 04 Dec 2013 16:33:31 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/03/2013 06:26 AM, Benoît Canet wrote:
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> block.c | 42 +++++++++++++++++++++++++++++++++++++-----
> 1 file changed, 37 insertions(+), 5 deletions(-)
>
> @@ -880,7 +881,14 @@ int bdrv_file_open(BlockDriverState **pbs, const char
> *filename,
> options = qdict_new();
> }
>
> - bs = bdrv_new("", "");
> + node_name = qdict_get_try_str(options, "node-name");
> + if (node_name && bdrv_find_node(node_name)) {
> + error_setg(errp, "Duplicate node name");
> + return -EINVAL;
This leaks options on failure.
> @@ -1053,6 +1070,21 @@ int bdrv_open(BlockDriverState *bs, const char
> *filename, QDict *options,
> options = qdict_new();
> }
>
> + node_name = qdict_get_try_str(options, "node-name");
> + if (node_name && bdrv_find_node(node_name)) {
> + error_setg(errp, "Duplicate node name");
> + return -EINVAL;
So does this.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC V3 0/7] Giving names to BlockDriverState graph nodes, Benoît Canet, 2013/12/03
- [Qemu-devel] [RFC V3 2/7] block: Allow the user to define "node-name" option., Benoît Canet, 2013/12/03
- Re: [Qemu-devel] [RFC V3 2/7] block: Allow the user to define "node-name" option.,
Eric Blake <=
- [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph., Benoît Canet, 2013/12/03
- Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph., Fam Zheng, 2013/12/03
- Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph., Eric Blake, 2013/12/04
- Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph., Benoît Canet, 2013/12/05
- Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph., Eric Blake, 2013/12/05
- Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph., Benoît Canet, 2013/12/05
- Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph., Eric Blake, 2013/12/05
- Re: [Qemu-devel] [RFC V3 3/7] qapi: Add skeletton of command to query a drive bs graph., Benoît Canet, 2013/12/05
[Qemu-devel] [RFC V3 1/7] block: Add bs->node_name to hold the name of a bs node of the bs graph., Benoît Canet, 2013/12/03