Re: [Qemu-devel] [PATCH 07/14] spapr: add helper to retrieve a PHB/device DrcEntry

[Michael Roth]

Quoting Alexey Kardashevskiy (2013-12-04 20:30:15)
> On 12/05/2013 12:19 PM, Michael Roth wrote:
> > Signed-off-by: Michael Roth <address@hidden>
> > ---
> >  hw/ppc/spapr.c         |   36 ++++++++++++++++++++++++++++++++++++
> >  include/hw/ppc/spapr.h |    2 ++
> >  2 files changed, 38 insertions(+)
> > 
> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> > index 0607559..2250ee1 100644
> > --- a/hw/ppc/spapr.c
> > +++ b/hw/ppc/spapr.c
> > @@ -277,6 +277,42 @@ static size_t create_page_sizes_prop(CPUPPCState *env, 
> > uint32_t *prop,
> >      return (p - prop) * sizeof(uint32_t);
> >  }
> >  
> > +DrcEntry *spapr_phb_to_drc_entry(uint64_t buid)
> > +{
> > +    int i;
> > +
> > +    for (i = 0; i < SPAPR_DRC_TABLE_SIZE; i++) {
> > +        if (drc_table[i].phb_buid == buid) {
> > +            return &drc_table[i];
> > +        }
> > +     }
> > +
> > +     return NULL;
> > +}
> > +
> > +DrcEntry *spapr_find_drc_entry(int drc_index)
> > +{
> > +    int i, j;
> > +
> > +    for (i = 0; i < SPAPR_DRC_TABLE_SIZE; i++) {
> > +        DrcEntry *phb_entry = &drc_table[i];
> > +        if (phb_entry->drc_index == drc_index) {
> > +            return phb_entry;
> > +        }
> > +        if (phb_entry->child_entries == NULL) {
> > +            continue;
> > +        }
> > +        for (j = 0; j < SPAPR_DRC_PHB_SLOT_MAX; j++) {
> > +            DrcEntry *entry = &phb_entry->child_entries[j];
> > +            if (entry->drc_index == drc_index) {
> > +                return entry;
> > +            }
> > +        }
> > +     }
> > +
> > +     return NULL;
> > +}
> 
> 
> spapr_find_drc_entry() is used in patches 1/3/4 but defined only in 7th
> patch, so patches 1..6 won't compile which breaks bisect.

Sorry, I messed this up re-organizing the patches. Will fix and re-test
for v2.

> 
> 
> 
> 
> -- 
> Alexey