Re: [Qemu-devel] [PATCH 05/13] target-arm: A64: add support for 2-src data processing and DIV

[Richard Henderson]

On 12/06/2013 12:09 PM, Peter Maydell wrote:
> On 5 December 2013 22:51, Richard Henderson <address@hidden> wrote:
>> On 12/06/2013 10:51 AM, Peter Maydell wrote:
>>> +    switch (opcode) {
>>> +    case 2: /* UDIV */
>>> +        handle_div(s, FALSE, sf, rm, rn, rd);
>>> +        break;
>>> +    case 3: /* SDIV */
>>> +        handle_div(s, TRUE, sf, rm, rn, rd);
>>> +        break;
>>
>> What are these all-caps TRUE/FALSE?  stdbool.h uses lower-case.
> 
> Good question, I wonder what system header is managing to define
> those for us? (there are some other bits of the source tree which
> use them too I see).
> 
>> Otherwise,
>>
>> Reviewed-by: Richard Henderson <address@hidden>
> 
> By the way, for these "otherwise reviewed-by" patches, would
> you prefer me to make the obvious trivial fix and include your
> R-b tag on the fixed version in the next respin, or to make the
> fix and leave the tag off so you can recheck it?

The former -- make the trivial fix and include the R-b.


r~