qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset


From: Fernando Luis Vazquez Cao
Subject: Re: [Qemu-devel] [PATCH] target-i386: clear guest TSC on reset
Date: Fri, 06 Dec 2013 18:20:04 +0900
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10

On 2013年12月06日 18:08, Paolo Bonzini wrote:
Il 06/12/2013 09:56, Fernando Luis Vázquez Cao ha scritto:

I will also be sending a patch that makes the TSC writeback
unconditional, but this one should probably be kept on hold
until it is properly tested.
If you test it, I can drop the "if" myself from your patch.
Unfortunately I will not have time to test patch 2 properly
for a while, so I think it would make sense to merge patch
1 first.
As I said, I'm not sure that patch 1 is an improvement...

Well it fixes and existing bug (without desynchronizing) and
I think it does not make the existing code uglier (it even gets
rid of one if statement! :) ). I guess the latter depends on
the eye of the beholder though.


I'll try to test it myself.

Thank you. Same here if time permits.

- Fernando



reply via email to

[Prev in Thread] Current Thread [Next in Thread]