Re: [Qemu-devel] [Qemu-trivial] [PATCH] help: add id suboption to -iscsi

[Michael Tokarev]

06.12.2013 19:08, Paolo Bonzini wrote:
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2089,7 +2089,7 @@ ETEXI
>  DEF("iscsi", HAS_ARG, QEMU_OPTION_iscsi,
>      "-iscsi [user=user][,password=password]\n"
>      "       [,header-digest=CRC32C|CR32C-NONE|NONE-CRC32C|NONE\n"
> -    "       [,initiator-name=iqn]\n"
> +    "       [,initiator-name=initiator-iqn][,id=target-iqn]\n"
>      "                iSCSI session parameters\n", QEMU_ARCH_ALL)
>  STEXI

I'm not sure this is clearer, to me it looks more confusing
than before.

The thing is that "id" suboption is automatic and is handled
in the option parsing code explicitly.

As far as I can see, "id" suboption is actually never used by
iscsi code, only initiator-name is.

What this change is for?

Thanks,

/mjt