[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH] eeprom93xx: fix coding style
|
From: |
Antony Pavlov |
|
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH] eeprom93xx: fix coding style |
|
Date: |
Sat, 7 Dec 2013 05:14:09 +0400 |
On Fri, 06 Dec 2013 22:59:29 +0400
Michael Tokarev <address@hidden> wrote:
> 04.12.2013 10:27, Antony Pavlov wrote:
> > scripts/checkpatch.pl reports about some style problems,
> > this commit fixes some of them:
>
> Thanks, applied to trivial-patches queue.
>
> I'm a bit afraid of this sort of patches - there are LOTS of
> coding style issues in current qemu code base, and applying
> a patch like this may open a really large can of worms...
>
> Generally it has been agreed to fix coding style only when
> doing some other code changes nearby, as far as I remember.
Some times ago there was a patch on adding DEC Tulip NIC support
(see http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02878.html).
In this patch the 93LC46B Serial EEPROM emulation was added.
But it's like reinventing the wheel because Stefan Weil already
have done this work in 2006! So I used eeprom93xx for the next
tulip patch version and occasionally I fixed some coding style issues.
--
Best regards,
Antony Pavlov