[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/5] scsi-bus: fix transfer length and direction for
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 1/5] scsi-bus: fix transfer length and direction for VERIFY command |
Date: |
Mon, 9 Dec 2013 14:02:33 +0100 |
The amount of bytes to transfer depends on the BYTCHK field.
If any data is transferred, it is sent to the device.
Cc: address@hidden
Tested-by: Hervé Poussineau <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi/scsi-bus.c | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c
index ea916d1..2d6ce4d 100644
--- a/hw/scsi/scsi-bus.c
+++ b/hw/scsi/scsi-bus.c
@@ -886,7 +886,6 @@ static int scsi_req_length(SCSICommand *cmd, SCSIDevice
*dev, uint8_t *buf)
case RELEASE:
case ERASE:
case ALLOW_MEDIUM_REMOVAL:
- case VERIFY_10:
case SEEK_10:
case SYNCHRONIZE_CACHE:
case SYNCHRONIZE_CACHE_16:
@@ -903,6 +902,16 @@ static int scsi_req_length(SCSICommand *cmd, SCSIDevice
*dev, uint8_t *buf)
case ALLOW_OVERWRITE:
cmd->xfer = 0;
break;
+ case VERIFY_10:
+ case VERIFY_12:
+ case VERIFY_16:
+ if ((buf[1] & 2) == 0) {
+ cmd->xfer = 0;
+ } else if ((buf[1] & 4) == 1) {
+ cmd->xfer = 1;
+ }
+ cmd->xfer *= dev->blocksize;
+ break;
case MODE_SENSE:
break;
case WRITE_SAME_10:
@@ -1100,6 +1109,9 @@ static void scsi_cmd_xfer_mode(SCSICommand *cmd)
case WRITE_VERIFY_12:
case WRITE_16:
case WRITE_VERIFY_16:
+ case VERIFY_10:
+ case VERIFY_12:
+ case VERIFY_16:
case COPY:
case COPY_VERIFY:
case COMPARE:
--
1.8.4.2
- [Qemu-devel] [PULL 0/5] SCSI patches for 2013-12-09, Paolo Bonzini, 2013/12/09
- [Qemu-devel] [PULL 1/5] scsi-bus: fix transfer length and direction for VERIFY command,
Paolo Bonzini <=
- [Qemu-devel] [PULL 2/5] scsi-disk: fix VERIFY emulation, Paolo Bonzini, 2013/12/09
- [Qemu-devel] [PULL 3/5] block/iscsi: introduce bdrv_co_{readv, writev, flush_to_disk}, Paolo Bonzini, 2013/12/09
- [Qemu-devel] [PULL 4/5] scsi-disk: fix WRITE SAME with large non-zero payload, Paolo Bonzini, 2013/12/09
- [Qemu-devel] [PULL 5/5] help: add id suboption to -iscsi, Paolo Bonzini, 2013/12/09
- Re: [Qemu-devel] [PULL 0/5] SCSI patches for 2013-12-09, Anthony Liguori, 2013/12/10