[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd Instructio
From: |
Tom Musta |
Subject: |
Re: [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd Instruction |
Date: |
Tue, 10 Dec 2013 11:47:43 -0600 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 |
On 12/9/2013 6:01 PM, Richard Henderson wrote:
> On 12/09/2013 07:46 AM, Tom Musta wrote:
>> + for (i = 0; i < 8; i++) {
>> + int index = (rs & (0xFFul) << (i*8)) >> (i*8);
>
> This is a silly expression. Better as
>
> int index = (rs >> (i * 8)) & 0xff;
>
>> + ra |= (1<<i);
>
> Unnecessary parens, and missing spaces around the operator.
Thanks, as always, for reviewing. I concur with most of the comments ...
will respond only to those that I either disagree with or have further
questions.
- [Qemu-devel] [PATCH 00/18] target-ppc: Base ISA V2.06 for Power7/Power8, Tom Musta, 2013/12/09
- [Qemu-devel] [PATCH 01/18] target-ppc: Add Flag for Power ISA V2.06, Tom Musta, 2013/12/09
- [Qemu-devel] [PATCH 02/18] target-ppc: Add ISA2.06 bpermd Instruction, Tom Musta, 2013/12/09
- [Qemu-devel] [PATCH 03/18] target-ppc: Add ISA2.06 divdeu[o] Instructions, Tom Musta, 2013/12/09
- [Qemu-devel] [PATCH 04/18] target-ppc: Add ISA2.06 divde[o] Instructions, Tom Musta, 2013/12/09
- [Qemu-devel] [PATCH 05/18] target-ppc: Add ISA 2.06 divwe[u][o] Instructions, Tom Musta, 2013/12/09
- [Qemu-devel] [PATCH 07/18] target-ppc: Add ISA 2.06 stbcx. and sthcx. Instructions, Tom Musta, 2013/12/09
- [Qemu-devel] [PATCH 06/18] target-ppc: Add ISA2.06 lbarx, lharx Instructions, Tom Musta, 2013/12/09