Re: [Qemu-devel] [PATCH 5/5] monitor: add object-del (QMP) and object_del (HMP) command

[Paolo Bonzini]

Il 10/12/2013 19:01, Eric Blake ha scritto:
> On 12/10/2013 10:00 AM, Paolo Bonzini wrote:
>> These two commands invoke the "unparent" method of Object.
>>
>> Signed-off-by: Paolo Bonzini <address@hidden>
>> ---
> 
>> +++ b/qapi-schema.json
>> @@ -2779,6 +2779,20 @@
>>    'gen': 'no' }
>>  
>>  ##
>> +# @object_del:
> 
> object-del, to match your commit message
> 
>> +#
>> +# Remove a QOM object.
>> +#
>> +# @id: the name of the QOM object to remove
>> +#
>> +# Returns: Nothing on success
>> +#          Error if @id is not a valid id for a QOM object
>> +#
>> +# Since: 2.0
>> +##
>> +{ 'command': 'object_del', 'data': {'id': 'str'} }
> 
> again, object-del
> 
>> +
>> +-> { "execute": "object-del", "arguments": { "id": "rng1" } }
>> +<- { "return": {} }
> 
> and fixing the json will make your example correct :)

It actually worked and was tested, :) because 'command' is only used to
generate the marshaling function name (qmp_marshal_input_object_del).
qmp-commands.hx used the right name, and that's enough.

Of course this doesn't mean qapi-schema.json shouldn't be fixed.

Paolo