[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] issue with vgabios lfb and virtio vga
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] issue with vgabios lfb and virtio vga |
Date: |
Thu, 12 Dec 2013 09:17:20 +0100 |
On Do, 2013-12-12 at 09:51 +1000, Dave Airlie wrote:
> Now the vgabios.c does a check of bar 0 and bar 1 to see if they are
> 0xfff1 masked, this protects against the the i/o bar but fails to
> protect against the LFB one as PCI BARs don't encode the size just the
> base address, and a 4k BAR can be aligned to a larger size.
> Any ideas? I seem to remember vgabios.c had a hack in the past for
> vmware, but I'm not sure.
The fallback to bar #1 *is* the vmware hack ;)
Something like the attached patch should do the trick.
cheers,
Gerd
fix
Description: Text Data