qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: add support for ld/st p


From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH v2 1/8] target-arm: A64: add support for ld/st pair
Date: Thu, 12 Dec 2013 11:43:10 +0000
User-agent: mu4e 0.9.9.6pre2; emacs 24.3.2

address@hidden writes:

> Hi,
>
> I saw a missing return below:
<snip>
>> +    default: /* Failed decoder tree? */
>> +        unallocated_encoding(s);
>> +        break;
>> +    }
>
> This doesn't seem right (break instead of return):
>
> default:
>     unallocated_encoding(s);
>     return;
> }

Good catch. I suspect it never hits though (or risu doesn't generate
enough unallocated versions).

-- 
Alex Bennée
QEMU/KVM Hacker for Linaro




reply via email to

[Prev in Thread] Current Thread [Next in Thread]