[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V5 7/7] Fix NOR flash device ID reading
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH V5 7/7] Fix NOR flash device ID reading |
|
Date: |
Thu, 12 Dec 2013 17:35:25 +0000 |
On 5 December 2013 21:35, Roy Franz <address@hidden> wrote:
> Fix NOR flash manufacturer and device ID reading. This now
> properly takes into account device widths and device max widths
> as required. The reading of these IDs uses the same max_width
> dependent addressing as CFI queries.
>
> The old code remains for chips that don't specify a device width,
> as the new code relies on a device width being set in order to
> properly operate. The existing code seems very broken.
>
> Only ident0 and ident1 are used in the new code, as other fields
> relate to the lock state of blocks in flash.
>
> The VExpress flash configuration has been updated to match
> the new code, as the existing definition was 'wrong' in order
> to return the expected results with the broken device ID code.
>
> Signed-off-by: Roy Franz <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
-- PMM