Re: [Qemu-devel] [PATCH v11 3/5] hw/intc: add allwinner A10 interrupt controller

[Peter Maydell]

On 11 December 2013 08:08, liguang <address@hidden> wrote:
> +static void aw_a10_pic_set_irq(void *opaque, int irq, int level)
> +{
> +    AwA10PICState *s = opaque;
> +
> +    if (level) {
> +        set_bit(irq%32, (void *)&s->irq_pending[irq/32]);

The % and / operators here should have spaces round them.

> +    }
> +    aw_a10_pic_update(s);
> +}
> +
> +static uint64_t aw_a10_pic_read(void *opaque, hwaddr offset, unsigned size)
> +{
> +    AwA10PICState *s = opaque;
> +    uint8_t index = (offset & 0xc)/4;

Spaces.

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

-- PMM