[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target-sh4: Use new qemu_ld/st opcodes
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] target-sh4: Use new qemu_ld/st opcodes |
Date: |
Fri, 13 Dec 2013 14:36:37 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Dec 13, 2013 at 09:36:13AM +0000, Alex Bennée wrote:
>
> address@hidden writes:
>
> > Signed-off-by: Aurelien Jarno <address@hidden>
> > ---
> > target-sh4/translate.c | 167
> > ++++++++++++++++++++++++++----------------------
> > 1 file changed, 90 insertions(+), 77 deletions(-)
> >
> > diff --git a/target-sh4/translate.c b/target-sh4/translate.c
> > index 2272eb0..87f532a 100644
> > --- a/target-sh4/translate.c
> > +++ b/target-sh4/translate.c
> > @@ -464,7 +464,7 @@ static void _decode_opc(DisasContext * ctx)
> > {
> > TCGv addr = tcg_temp_new();
> > tcg_gen_addi_i32(addr, REG(B11_8), B3_0 * 4);
> > - tcg_gen_qemu_st32(REG(B7_4), addr, ctx->memidx);
> > + tcg_gen_qemu_st_i32(REG(B7_4), addr, ctx->memidx, MO_TEUL);
> > tcg_temp_free(addr);
> <snip>
>
> There seems to be a fix of tabs and spaces in that patch.
>
Indeed, this file is partly tabs indented for historical reasons, so
they are changed to space in the patch, to conform to the QEMU coding
style. AFAIK there is a consensus that things should be done that way.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net