[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 6/9] qapi script: support pre-defined enum ty
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH V4 6/9] qapi script: support pre-defined enum type as discriminator in union |
Date: |
Fri, 13 Dec 2013 07:10:38 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/10/2013 10:48 PM, Wenchao Xia wrote:
> By default, any union will automatically generate a enum type as
> "[UnionName]Kind" in C code, and it is duplicated when the discriminator
> is specified as a pre-defined enum type in schema. After this patch,
> the pre-defined enum type will be really used as the switch case
> condition in generated C code, if discriminator is an enum field.
>
> Signed-off-by: Wenchao Xia <address@hidden>
> ---
> docs/qapi-code-gen.txt | 8 ++++++--
> scripts/qapi-types.py | 18 ++++++++++++++----
> scripts/qapi-visit.py | 23 ++++++++++++++++-------
> scripts/qapi.py | 4 +++-
> 4 files changed, 39 insertions(+), 14 deletions(-)
>
> diff --git a/docs/qapi-code-gen.txt b/docs/qapi-code-gen.txt
> index 0728f36..f00640b 100644
> --- a/docs/qapi-code-gen.txt
> +++ b/docs/qapi-code-gen.txt
> @@ -123,11 +123,15 @@ And it looks like this on the wire:
>
> Flat union types avoid the nesting on the wire. They are used whenever a
> specific field of the base type is declared as the discriminator ('type' is
> -then no longer generated). The discriminator must always be a string field.
> +then no longer generated). The discriminator can be a string field or a
> +predefined enum field. If it is a string field, a hidden enum type will be
> +generated as "[UNION_NAME]Kind". If it is an enum field, compile time check
s/compile/a compile/
Minor enough that I'm okay giving:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH V4 0/9] qapi script: support enum as discriminator and better enum name, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 6/9] qapi script: support pre-defined enum type as discriminator in union, Wenchao Xia, 2013/12/11
- Re: [Qemu-devel] [PATCH V4 6/9] qapi script: support pre-defined enum type as discriminator in union,
Eric Blake <=
- [Qemu-devel] [PATCH V4 2/9] qapi script: add check for duplicated key, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 5/9] qapi script: use same function to generate enum string, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 1/9] qapi script: remember enum values, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 4/9] qapi script: code move for generate_enum_name(), Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 9/9] qapi script: do not add "_" for every capitalized char in enum, Wenchao Xia, 2013/12/11
- [Qemu-devel] [PATCH V4 8/9] qapi: convert BlockdevOptions to use enum discriminator, Wenchao Xia, 2013/12/11