[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 0/6] block: allow commit active as top
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v6 0/6] block: allow commit active as top |
Date: |
Fri, 13 Dec 2013 19:28:25 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 26.11.2013 um 06:45 hat Fam Zheng geschrieben:
> Previously live commit of active block device is not supported, this series
> implements it and updates corresponding qemu-iotests cases.
>
> This series is based on BlockJobType enum QAPI series.
>
> v6: Address comments from Stefan:
>
> [04/06] commit: support commit active layer
> Fix wording.
> [05/06] qemu-iotests: update test cases for commit active
> Drop is_active.
>
> Experimental for reviewers: the side by side diff against previous series:
>
> http://goo.gl/vgN6mc
>
> v5: Address comments from Eric and Paolo:
> Add mirror_start_job and front end wrapper. [Paolo]
> Base on BlockJobType enum in QAPI. [Eric]
> Drop "common" sync mode. [Eric]
>
> v4: Rewrite to reuse block/mirror.c.
> When committing the active layer, the job is internally a mirror job with
> type name faked to "commit".
> When the job completes, the BDSes are swapped, so the base image become
> active and [top, base) dropped.
>
> Fam Zheng (6):
> mirror: don't close target
> mirror: move base to MirrorBlockJob
> block: add commit_active_start()
> commit: support commit active layer
> qemu-iotests: update test cases for commit active
> commit: remove unused check
>
> block/commit.c | 8 +----
> block/mirror.c | 77
> +++++++++++++++++++++++++++++++++++++++--------
> blockdev.c | 9 ++++--
> include/block/block_int.h | 22 ++++++++++++--
> qapi-schema.json | 5 +--
> tests/qemu-iotests/040 | 74 ++++++++++++++++++++-------------------------
> 6 files changed, 126 insertions(+), 69 deletions(-)
Patches 1-3 and 6 are: Reviewed-by: Kevin Wolf <address@hidden>
Patch 4 needs a fix, patch 5 didn't apply any more and needs a rebase.
Kevin