Re: [Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from qdict_flatten_qdict()

[Kevin Wolf]

Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
> delete is always set to true, therefore it can be removed.
> 
> Signed-off-by: Max Reitz <address@hidden>

Nope, this can't be right.

delete is always set, except for simple types in the top-level QDict.
They get deleted now instead of being left alone.

But it coincides pretty well with the new loop condition. Leaving
uninteresting stuff aside, the loop looks now like this:

    while (entry != NULL) {
        ...
        entry = qdict_first(qdict);
    }

So the loop only terminates when all elements have been removed. How
lucky we are that it really does remove all elements now!


Perhaps some other code is broken, or I missed something else, but
qemu-iotests 067 segfaults after this patch.

Kevin