Re: [Qemu-devel] [PATCH v5 20/22] qapi: QMP interface for blkdebug and blkverify

[Kevin Wolf]

Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
> Add structures to support blkdebug and blkverify in blockdev-add.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  qapi-schema.json | 94 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 90 insertions(+), 4 deletions(-)
> 
> diff --git a/qapi-schema.json b/qapi-schema.json
> index c3c939c..6ce016c 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -4166,6 +4166,94 @@
>              '*pass-discard-other': 'bool' } }
>  
>  ##
> +# @BlkdebugInjectErrorOptions
> +#
> +# Describes a single error injection for blkdebug.
> +#
> +# @event:       trigger event name
> +#
> +# @state:       #optional the state identifier blkdebug needs to be in to
> +#               actually trigger the event; defaults to "any"
> +#
> +# @error:       #optional error identifier (errno) to be returned; defaults 
> to
> +#               EIO
> +#
> +# @sector:      #optional specifies the sector index which has to be affected
> +#               in order to actually trigger the event; defaults to "any
> +#               sector"
> +#
> +# @once:        #optional disables further events after this one has been
> +#               triggered; defaults to false
> +#
> +# @immediately: #optional fail immediately; defaults to false
> +#
> +# Since: 2.0
> +##
> +{ 'type': 'BlkdebugInjectErrorOptions',
> +  'data': { 'event': 'str',

I bet Eric will tell you that an enum for event would be much nicer. ;-)

Reviewed-by: Kevin Wolf <address@hidden>