qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from qdict_flatte


From: Max Reitz
Subject: Re: [Qemu-devel] [PATCH v5 05/22] qdict: Remove delete from qdict_flatten_qdict()
Date: Sat, 14 Dec 2013 01:05:44 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1

On 13.12.2013 19:58, Kevin Wolf wrote:
Am 13.12.2013 um 18:10 hat Max Reitz geschrieben:
delete is always set to true, therefore it can be removed.

Signed-off-by: Max Reitz <address@hidden>
Nope, this can't be right.

delete is always set, except for simple types in the top-level QDict.
They get deleted now instead of being left alone.

Ah, I don't know how I missed the "if (prefix)"... Well then, I feared requiring delete would somehow require qdict_flatten_qlist() to have something similar, but if this can be wrong for top-level elements only, at least that won't be the case.

Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]