Re: [Qemu-devel] [PATCH RFC 2/3] qapi script: add support of event

[Wenchao Xia]

于 2013/12/13 21:31, Eric Blake 写道:
> On 11/12/2013 06:44 PM, Wenchao Xia wrote:
> > Nested structure is not supported now, so following define is not valid:
> > { 'event': 'EVENT_C',
> >    'data': { 'a': { 'a_a', 'str', 'a_b', 'str' }, 'b': 'int' }
>
> But what IS valid?  You need to document this in docs/qapi-code-gen.txt
> at a bare minimum.
>
> This patch series is hard to review, and still has the RFC subject line.
>   At this point, I think it's worth rebasing and resending what you have;
> even if it needs more review, it will at least get it to a state that is
> easier to review.
  Sure, I will wait some time and respin.


> > +++ b/scripts/qapi-event.py
> > @@ -0,0 +1,355 @@
> > +#
> > +# QAPI event generator
> > +#
> > +# Copyright IBM, Corp. 2013
> > +#
> > +# Authors:
> > +#  Wenchao Xia <address@hidden>
> > +#
> > +# This work is licensed under the terms of the GNU GPLv2.
>
> Can you please use GPLv2+ (that is, add the "or later" clause)?  We
> already have GPLv2-only code, but I don't want to increase the size of
> that unfortunate license choice.