[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/11] qdev: add to BusState "hotplug-handler" l
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 04/11] qdev: add to BusState "hotplug-handler" link |
Date: |
Mon, 16 Dec 2013 16:53:03 +0100 |
On Mon, 16 Dec 2013 16:26:25 +0100
Igor Mammedov <address@hidden> wrote:
> On Sat, 14 Dec 2013 17:05:57 +1000
> Peter Crosthwaite <address@hidden> wrote:
>
[...]
> > >
> > > QTAILQ_INIT(&bus->children);
> > > + object_property_add_link(obj, QDEV_HOTPLUG_HANDLER_PROPERTY,
> > > + TYPE_HOTPLUG_HANDLER,
> > > + (Object **)&bus->hotplug_handler, NULL);
> >
> > I think failure of this is fatal. When the patches go through,
> > probably want to &error_abort.
[...]
>
> But more to the point, bus could be created during hotplug, and
> we do not want to abort guest, instead hotplug operation should fail.
> In this case following setting of QDEV_HOTPLUG_HANDLER_PROPERTY
> will fail if object_property_add_link() failed before.
In following patches there is a couple places asking for being replaced
with &error_abort, so if your patches get in before respin, I'll gladly
use &error_abort there.
- [Qemu-devel] [PATCH 01/11] qom: do not register interface "types" in the type table, (continued)
- [Qemu-devel] [PATCH 06/11] hw/acpi: move typeinfo to the file end, Igor Mammedov, 2013/12/13
- [Qemu-devel] [PATCH 07/11] qdev:pci: refactor PCIDevice to use generic "hotpluggable" property, Igor Mammedov, 2013/12/13
- [Qemu-devel] [PATCH 08/11] acpi/piix4pm: convert ACPI PCI hotplug to use hotplug-handler API, Igor Mammedov, 2013/12/13
- [Qemu-devel] [PATCH 05/11] qdev: add "hotpluggable" property to Device, Igor Mammedov, 2013/12/13
- [Qemu-devel] [PATCH 09/11] pci/shpc: convert SHPC hotplug to use hotplug-handler API, Igor Mammedov, 2013/12/13
- [Qemu-devel] [PATCH 10/11] pci/pcie: convert PCIE hotplug to use hotplug-handler API, Igor Mammedov, 2013/12/13
- [Qemu-devel] [PATCH 11/11] hw/pci: switch to a generic hotplug handling for PCIDevice, Igor Mammedov, 2013/12/13