[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 22/38] memory: cpu_physical_memory_get_dirty() is us
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 22/38] memory: cpu_physical_memory_get_dirty() is used as returning a bool |
Date: |
Tue, 17 Dec 2013 16:25:58 +0100 |
Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
include/exec/memory-internal.h | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
index edca8a8..fa28fc6 100644
--- a/include/exec/memory-internal.h
+++ b/include/exec/memory-internal.h
@@ -40,11 +40,10 @@ void *qemu_get_ram_ptr(ram_addr_t addr);
void qemu_ram_free(ram_addr_t addr);
void qemu_ram_free_from_ptr(ram_addr_t addr);
-static inline int cpu_physical_memory_get_dirty(ram_addr_t start,
- ram_addr_t length,
- unsigned client)
+static inline bool cpu_physical_memory_get_dirty(ram_addr_t start,
+ ram_addr_t length,
+ unsigned client)
{
- int ret = 0;
ram_addr_t addr, end;
assert(client < DIRTY_MEMORY_NUM);
@@ -52,10 +51,12 @@ static inline int cpu_physical_memory_get_dirty(ram_addr_t
start,
end = TARGET_PAGE_ALIGN(start + length);
start &= TARGET_PAGE_MASK;
for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
- ret |= test_bit(addr >> TARGET_PAGE_BITS,
- ram_list.dirty_memory[client]);
+ if (test_bit(addr >> TARGET_PAGE_BITS,
+ ram_list.dirty_memory[client])) {
+ return true;
+ }
}
- return ret;
+ return false;
}
static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr,
--
1.8.3.1
- Re: [Qemu-devel] [PATCH 17/38] memory: split dirty bitmap into three, (continued)
- [Qemu-devel] [PATCH 19/38] memory: unfold cpu_physical_memory_set_dirty() in its only user, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 18/38] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 20/38] memory: unfold cpu_physical_memory_set_dirty_flag(), Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 21/38] memory: make cpu_physical_memory_get_dirty() the main function, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 22/38] memory: cpu_physical_memory_get_dirty() is used as returning a bool,
Juan Quintela <=
- [Qemu-devel] [PATCH 23/38] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 24/38] memory: use find_next_bit() to find dirty bits, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 25/38] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations, Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 27/38] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty(), Juan Quintela, 2013/12/17
- [Qemu-devel] [PATCH 29/38] memory: cpu_physical_memory_set_dirty_tracking() should return void, Juan Quintela, 2013/12/17