Re: [Qemu-devel] [PATCH 38/38] ram: align ram_addr_t's regions in multiples of 64

[Juan Quintela]

Juan Quintela <address@hidden> wrote:
> This allows us to use fastest path for bitmap operations.
> This was based on Paolo idea/code.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
>  exec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/exec.c b/exec.c
> index be421e5..faf3f59 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1108,7 +1108,7 @@ static ram_addr_t find_ram_offset(ram_addr_t size)
>      QTAILQ_FOREACH(block, &ram_list.blocks, next) {
>          ram_addr_t end, next = RAM_ADDR_MAX;
>
> -        end = block->offset + block->length;
> +        end = ROUND_UP(block->offset + block->length, TARGET_PAGE_SIZE * 64);
>
>          QTAILQ_FOREACH(next_block, &ram_list.blocks, next) {
>              if (next_block->offset >= end) {

NAK

This patch is giving me trouble.  iht stays at 868kbytes forever,
removing this patch makes things work again.

Paolo, any idea?

will drop it until I found what/where the problem is.

Later, Juan.

16:51:10 DEBUG| (monitor hmp1) Response to 'info migrate'
16:51:10 DEBUG| (monitor hmp1)    capabilities: xbzrle: off x-rdma-pin-all: off 
auto-converge: off zero-blocks: off 
16:51:10 DEBUG| (monitor hmp1)    Migration status: active
16:51:10 DEBUG| (monitor hmp1)    total time: 1515704 milliseconds
16:51:10 DEBUG| (monitor hmp1)    expected downtime: 30 milliseconds
16:51:10 DEBUG| (monitor hmp1)    setup: 6 milliseconds
16:51:10 DEBUG| (monitor hmp1)    transferred ram: 5168004 kbytes
16:51:10 DEBUG| (monitor hmp1)    throughput: 44.17 mbps
16:51:10 DEBUG| (monitor hmp1)    remaining ram: 868 kbytes
16:51:10 DEBUG| (monitor hmp1)    total ram: 1065688 kbytes
16:51:10 DEBUG| (monitor hmp1)    duplicate: 228523 pages
16:51:10 DEBUG| (monitor hmp1)    skipped: 0 pages
16:51:10 DEBUG| (monitor hmp1)    normal: 37899 pages
16:51:10 DEBUG| (monitor hmp1)    normal bytes: 151596 kbytes
16:51:11 DEBUG| (monitor hmp1) Sending command 'cont' 
16:51:11 DEBUG| Send command: cont
16:51:11 DEBUG| Host does not support