Re: [Qemu-devel] [PATCH 2/2] xen: build on ARM

[Peter Maydell]

On 17 December 2013 17:31, Stefano Stabellini
<address@hidden> wrote:
> - add __arm__ and __aarch64__ cases in xen-mapcache.c.
> --- a/xen-mapcache.c
> +++ b/xen-mapcache.c
> @@ -33,10 +33,10 @@
>  #  define DPRINTF(fmt, ...) do { } while (0)
>  #endif
>
> -#if defined(__i386__)
> +#if defined(__i386__) || defined(__arm__)
>  #  define MCACHE_BUCKET_SHIFT 16
>  #  define MCACHE_MAX_SIZE     (1UL<<31) /* 2GB Cap */
> -#elif defined(__x86_64__)
> +#elif defined(__x86_64__) || defined(__aarch64__)
>  #  define MCACHE_BUCKET_SHIFT 20
>  #  define MCACHE_MAX_SIZE     (1UL<<35) /* 32GB Cap */
>  #endif

Per-host-architecture ifdef ladders are kind of nasty. What's this
code actually trying to do ? (looks like maybe "64 bit host addresses
vs 32 bit host addresses" ?)

thanks
-- PMM