qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/38] memory: all users of cpu_physical_memory_


From: Orit Wasserman
Subject: Re: [Qemu-devel] [PATCH 08/38] memory: all users of cpu_physical_memory_get_dirty used only one flag
Date: Wed, 18 Dec 2013 12:09:51 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0

On 12/17/2013 05:25 PM, Juan Quintela wrote:
So cpu_physical_memory_get_dirty_flags is not needed anymore

Signed-off-by: Juan Quintela <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
  include/exec/memory-internal.h | 9 ++-------
  1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h
index 0b25c3f..53cfe83 100644
--- a/include/exec/memory-internal.h
+++ b/include/exec/memory-internal.h
@@ -44,11 +44,6 @@ void qemu_ram_free_from_ptr(ram_addr_t addr);
  #define CODE_DIRTY_FLAG      0x02
  #define MIGRATION_DIRTY_FLAG 0x08

-static inline int cpu_physical_memory_get_dirty_flags(ram_addr_t addr)
-{
-    return ram_list.phys_dirty[addr >> TARGET_PAGE_BITS];
-}
-
  static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr,
                                                        int dirty_flag)
  {
@@ -67,7 +62,7 @@ static inline bool cpu_physical_memory_is_dirty(ram_addr_t 
addr)

  static inline int cpu_physical_memory_get_dirty(ram_addr_t start,
                                                  ram_addr_t length,
-                                                int dirty_flags)
+                                                int dirty_flag)
  {
      int ret = 0;
      ram_addr_t addr, end;
@@ -75,7 +70,7 @@ static inline int cpu_physical_memory_get_dirty(ram_addr_t 
start,
      end = TARGET_PAGE_ALIGN(start + length);
      start &= TARGET_PAGE_MASK;
      for (addr = start; addr < end; addr += TARGET_PAGE_SIZE) {
-        ret |= cpu_physical_memory_get_dirty_flags(addr) & dirty_flags;
+        ret |= cpu_physical_memory_get_dirty_flag(addr, dirty_flag);
      }
      return ret;
  }


Reviewed-by: Orit Wasserman <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]