[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qdev: Drop misleading qbus_free() function
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH] qdev: Drop misleading qbus_free() function |
|
Date: |
Wed, 18 Dec 2013 17:33:27 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
Am 18.12.2013 17:15, schrieb Stefan Hajnoczi:
> Same reasoning as commit 02a5c4c97422b40034f31265e0f139f7846172a8
> ("qdev: Drop misleading qdev_free() function"). The qbus_free()
> function removes the child from the namespace and decrements the
> reference count. It does not, however, guarantee to free the child
> since the refcount may still be held.
>
> Just call object_unparent() directly.
>
> Suggested-by: Markus Armbruster <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Thanks, nice and trivial, applied to qom-next:
https://github.com/afaerber/qemu-cpu/commits/qom-next
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg