[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 20/22] target-microblaze: Add address-space p
From: |
Peter Crosthwaite |
Subject: |
Re: [Qemu-devel] [PATCH v2 20/22] target-microblaze: Add address-space property |
Date: |
Thu, 19 Dec 2013 16:22:47 +1000 |
On Thu, Dec 19, 2013 at 3:51 PM, <address@hidden> wrote:
> From: "Edgar E. Iglesias" <address@hidden>
>
> Signed-off-by: Edgar E. Iglesias <address@hidden>
> ---
> target-microblaze/cpu.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/target-microblaze/cpu.c b/target-microblaze/cpu.c
> index 0ef9aa4..6d39d3d 100644
> --- a/target-microblaze/cpu.c
> +++ b/target-microblaze/cpu.c
> @@ -93,6 +93,9 @@ static void mb_cpu_realizefn(DeviceState *dev, Error **errp)
> CPUState *cs = CPU(dev);
> MicroBlazeCPUClass *mcc = MICROBLAZE_CPU_GET_CLASS(dev);
>
> +#ifndef CONFIG_USER_ONLY
> + cpu_address_space_init(cs, cs->as);
> +#endif
> cpu_reset(cs);
> qemu_init_vcpu(cs);
>
> @@ -123,6 +126,9 @@ static const VMStateDescription vmstate_mb_cpu = {
> };
>
> static Property mb_properties[] = {
> +#ifndef CONFIG_USER_ONLY
> + DEFINE_PROP_ADDRESS_SPACE("address-space", CPUState, as),
> +#endif
Why not add it as a property on the base CPU level?
Regards,
Peter
> DEFINE_PROP_UINT32("xlnx.base-vectors", MicroBlazeCPU, base_vectors, 0),
> DEFINE_PROP_END_OF_LIST(),
> };
> --
> 1.7.10.4
>
>
- [Qemu-devel] [PATCH v2 11/22] exec: Make stq_*_phys input an AddressSpace, (continued)
- [Qemu-devel] [PATCH v2 11/22] exec: Make stq_*_phys input an AddressSpace, edgar . iglesias, 2013/12/19
- [Qemu-devel] [PATCH v2 12/22] exec: Make stl_*_phys input an AddressSpace, edgar . iglesias, 2013/12/19
- [Qemu-devel] [PATCH v2 13/22] exec: Make stl_phys_notdirty input an AddressSpace, edgar . iglesias, 2013/12/19
- [Qemu-devel] [PATCH v2 14/22] exec: Make stw_*_phys input an AddressSpace, edgar . iglesias, 2013/12/19
- [Qemu-devel] [PATCH v2 15/22] exec: Make stb_phys input an AddressSpace, edgar . iglesias, 2013/12/19
- [Qemu-devel] [PATCH v2 16/22] exec: Make cpu_physical_memory_write_rom input an AS, edgar . iglesias, 2013/12/19
- [Qemu-devel] [PATCH v2 17/22] exec: Make cpu_memory_rw_debug use the CPUs AS, edgar . iglesias, 2013/12/19
- [Qemu-devel] [PATCH v2 18/22] memory: Add address_space_find_by_name(), edgar . iglesias, 2013/12/19
- [Qemu-devel] [PATCH v2 19/22] qdev: Add qdev property type for AddressSpaces, edgar . iglesias, 2013/12/19
- [Qemu-devel] [PATCH v2 20/22] target-microblaze: Add address-space property, edgar . iglesias, 2013/12/19
- Re: [Qemu-devel] [PATCH v2 20/22] target-microblaze: Add address-space property,
Peter Crosthwaite <=
- [Qemu-devel] [PATCH v2 21/22] petalogix-ml605: Create the CPU with object_new(), edgar . iglesias, 2013/12/19
- [Qemu-devel] [PATCH v2 22/22] petalogix-ml605: Make the LMB visible only to the CPU, edgar . iglesias, 2013/12/19